fix: Fix to avoid task creation for violent and meaning less prompts when deployment reuse existing AI Foundry Project. #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…based on existing and new deployment
NirajC-Microsoft
requested review from
Avijit-Microsoft,
Fr4nc3,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
marktayl1
as code owners
infra/main.bicep
Outdated
| { | ||
| name: 'pep-${aiFoundryAiServicesResourceName}' | ||
| customNetworkInterfaceName: 'nic-${aiFoundryAiServicesResourceName}' | ||
| name: 'pep-${aiFoundryAiServicesConfiguration.?name ?? 'aisa-${solutionPrefix}'}' |
There was a problem hiding this comment.
This change is not required as the check is already added in line 701
Prajwal-Microsoft
approved these changes
Jul 9, 2025
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
blessing-msft
pushed a commit
that referenced
this pull request
Aug 1, 2025
fix: Fix to avoid task creation for violent and meaning less prompts when deployment reuse existing AI Foundry Project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to improve the handling of existing AI Foundry projects and resources in the
infra/main.bicepfile. The updates ensure that the code can dynamically use existing resources when specified, reducing redundancy and enhancing flexibility.Enhancements for handling existing AI Foundry resources:
aiFoundryAiServicesResourceNamebased on the presence of an existing Foundry project resource ID. If the resource ID exists, the name is derived from it; otherwise, default logic is used.aiFoundryAiServicesConfigurationor the default naming convention, ensuring consistency and adaptability.aiFoundryAiProjectNameto support existing Foundry projects, deriving the name from the resource ID when applicable. …based on existing and new deploymentPurpose
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information